Skip to content

Conversation

staudtMarius
Copy link
Member

Resolves #682

@staudtMarius staudtMarius added the enhancement New feature or request label Apr 24, 2023
@staudtMarius staudtMarius added this to the Version 3.1 milestone Apr 24, 2023
@staudtMarius staudtMarius self-assigned this Apr 24, 2023
@staudtMarius staudtMarius marked this pull request as ready for review April 27, 2023 10:38
@sebastian-peter sebastian-peter modified the milestones: Version 3.1, Version 4.0 Jul 25, 2023
Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Here's some things I noticed.

Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only had some minor adaptations from my side, looks very good overall!

@sebastian-peter sebastian-peter merged commit 0dfba3b into dev Aug 1, 2023
@sebastian-peter sebastian-peter deleted the ms/#682-method-handleEntity-throws-Exception branch August 1, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make the method handleEntity throw an Exception if it catches one

2 participants