-
Notifications
You must be signed in to change notification settings - Fork 2
chore(constants): re-introduce pecorino #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
these may change with pecorino regenesis work going on right now. this PR is likely not correct |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🦢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reviewed correctness of addresses and argument order in constructors
Pecorino needs to be added to KnownChains and all match blocks updated, oh and some Type::pecorino()
shortcut instantiators should be restored
7b33786
to
ca85eb2
Compare
@@ -46,12 +51,30 @@ impl SignetEnvironmentConstants { | |||
|
|||
impl TryFrom<KnownChains> for SignetEnvironmentConstants { | |||
type Error = ParseChainError; | |||
<<<<<<< HEAD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey! a committed merge conflict! that's my thing! stop stealing my bits!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
man graphite what did you do, making me look like an amateur here 😭
(also no. i am stealing your bits and bytes)
ca85eb2
to
f1b16aa
Compare
pub const HOST_ZENITH: Address = address!("0xbe45611502116387211D28cE493D6Fb3d192bc4E"); | ||
/// `Orders` contract address for the Pecorino testnet host chain. | ||
pub const HOST_ORDERS: Address = address!("0x4E8cC181805aFC307C83298242271142b8e2f249"); | ||
/// `Passage` contract address for the Pecorino testnet host chain. | ||
pub const HOST_PASSAGE: Address = address!("0xd553C4CA4792Af71F4B61231409eaB321c1Dd2Ce"); | ||
/// `Transactor` contract address for the Pecorino testnet host chain. | ||
pub const HOST_TRANSACTOR: Address = address!("0x1af3A16857C28917Ab2C4c78Be099fF251669200"); | ||
|
||
/// USDC token for the Pecorino testnet host chain. | ||
pub const HOST_USDC: Address = address!("0x885F8DB528dC8a38aA3DDad9D3F619746B4a6A81"); | ||
/// USDT token for the Pecorino testnet host chain. | ||
pub const HOST_USDT: Address = address!("0x7970D259D4a96764Fa9B23FF0715A35f06f52D1A"); | ||
/// WBTC token for the Pecorino testnet host chain. | ||
pub const HOST_WBTC: Address = address!("0x9aeDED4224f3dD31aD8A0B1FcD05E2d7829283a7"); | ||
/// WETH token for the Pecorino testnet host chain. | ||
pub const HOST_WETH: Address = address!("0x572C4d72080ed9E9997509b583a22B785B70cB3f"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manually verified updated host addresses
pub const RU_WETH: Address = address!("0x0000000000000000007369676e65742d77657468"); | ||
/// WBTC token for the Pecorino testnet RU chain. | ||
pub const RU_WBTC: Address = address!("0x0000000000000000007369676e65742D77627463"); | ||
/// `Orders` contract address for the Pecorino testnet RU chain. | ||
pub const RU_ORDERS: Address = address!("0x000000000000007369676E65742D6f7264657273"); | ||
/// `Passage` contract address for the Pecorino testnet RU chain. | ||
/// This is currently a dummy value and will be replaced with the actual Passage contract address in the future. | ||
pub const RU_PASSAGE: Address = address!("0x0000000000007369676E65742D70617373616765"); | ||
/// The WETH9-based wrapped native USD token contract. | ||
/// This is signet's native token in wrapped form. | ||
pub const WRAPPED: Address = address!("0x0000000000000000007369676e65742D77757364"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manually verified updated rollup addresses
Based on the recently updated constants on the node.
Closes ENG-1182