Skip to content

Enabling options watch so that if anything changes it will refresh countUp #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dougloyo
Copy link

@dougloyo dougloyo commented Mar 2, 2018

Hi,

This pull request enables options change watch to trigger an update on the countUp instance if any property of the options object changes.
Use case: We needed to dynamically change the suffix part of the options. For example: if our number was a percentage "97%" and then we needed it to be a number "183.23" we needed to change the options.suffix value and have countUp update.

Additionally we cleaned up the options extend because generally speaking this is when your plugin or module has default options to be replaced with the ones being passed in.
For example:
if you had: var options={ someDefaultValue:5 }; inside of your module/plugin.
you would use extends to override that value.
$scope.options would probably be = { someDefaultValue:6, otherValue:10 }
angular.extend(options, $scope.options);

Please let me know if this makes sense.

@inorganik
Copy link
Owner

Looks good, you just need to build your changes with gulp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants