LW-13053 Add estimated ROS #1957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iccicci
requested review from
rhyslbw,
mkazlauskas,
mchappell,
AngelCastilloB and
mirceahasegan
Allure Report
processReports: ✅ test report for 2199192d
|
mkazlauskas
requested changes
Jul 23, 2025
iccicci
force-pushed
the
feat/estimated-ros
branch
from
5a5aec6 to
9520e73
Compare
iccicci
force-pushed
the
feat/estimated-ros
branch
from
9520e73 to
2199192
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Proposed solution
Since Lace shows the ROS only when showing stake pools details, enriching the
enrichStakePoolfunction with the ROS estimation is enough to compute the estimated ROS when needed.The ROS computation is based on Shelley ledger specifications (with Conway amendment); the main difference is that ledger specifications uses data from the snapshot on epoch rollovers while here live data is used.
The computation requires some data from the network, the genesis parameter and protocol parameters, so the
StakePoolServicenow fetches this data from aNetworkInfoProvideror BF directly.About the stake pool data, almost all data are already fetched; the only exception is the distinction between member stake and operator stake and BF doesn't offer an API to get it... strictly required to compute the
memberReward. 😞The first idea was to fetch the controlled stack for each pool owner, but the high number of required HTTP requests discouraged me...
By chances I decided to postpone this problem and to go on... and... in next steps, I found a mathematical trick to compute the ROS without computing the
memberReward! 💪 🕺Enjoy reading the code for details. 😉
Testing
Manually tested.