Skip to content

Conversation

rhyslbw
Copy link
Member

@rhyslbw rhyslbw commented Aug 7, 2025

Proposed solution

  • Makes it possible to sign arbitrary messages with the managed stake keys
  • Also corrects the invalid copy with a technically accurate description

Testing

CIP-30 signData should produce the same result

Screenshots

image image image

@rhyslbw rhyslbw requested a review from a team as a code owner August 7, 2025 00:15
@lace-bot
Copy link
Collaborator

lace-bot commented Aug 7, 2025

Allure Report

allure-report-publisher generated test report!

processReports: ✅ test report for 63de07f4

passed failed skipped flaky total result
Total 33 0 4 0 37

Copy link
Member

@AngelCastilloB AngelCastilloB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @rhyslbw

@mkazlauskas mkazlauskas force-pushed the feature/sign-message-stake-key-support branch 3 times, most recently from 6ea24b5 to 49909c9 Compare August 7, 2025 06:39
we were displaying only 'cose key' structure that
wraps the raw key which does not for Glacier Drop
@mkazlauskas mkazlauskas force-pushed the feature/sign-message-stake-key-support branch from 49909c9 to d16036b Compare August 7, 2025 06:40
Copy link

sonarqubecloud bot commented Aug 7, 2025

@mchappell mchappell enabled auto-merge (squash) August 7, 2025 16:28
@mchappell mchappell merged commit c2b475a into main Aug 7, 2025
27 checks passed
@mchappell mchappell deleted the feature/sign-message-stake-key-support branch August 7, 2025 16:43
mchappell pushed a commit that referenced this pull request Aug 7, 2025
* refactor: correct sign message copy

* feat: support stake key message signing

* feat: display raw key in message signing result

we were displaying only 'cose key' structure that
wraps the raw key which does not for Glacier Drop

* feat(core): limit addresses drawer and add scroll

* test: fix message signing e2e

* chore(core): fix scrollbars styles

---------

Co-authored-by: Martynas Kazlauskas <martynas.kazlauskas@iohk.io>
Co-authored-by: Mircea Hasegan <mircea.hasegan@iohk.io>
Co-authored-by: Lukasz Jagiela <Lukasz.Jagiela@iohk.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants