-
Notifications
You must be signed in to change notification settings - Fork 12
LW-13371 Feature/sign message stake key support #1970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allure Report
processReports: ✅ test report for 63de07f4
|
AngelCastilloB
approved these changes
Aug 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @rhyslbw
6ea24b5
to
49909c9
Compare
we were displaying only 'cose key' structure that wraps the raw key which does not for Glacier Drop
49909c9
to
d16036b
Compare
pczeglik-iohk
approved these changes
Aug 7, 2025
ljagiela
approved these changes
Aug 7, 2025
|
mchappell
pushed a commit
that referenced
this pull request
Aug 7, 2025
* refactor: correct sign message copy * feat: support stake key message signing * feat: display raw key in message signing result we were displaying only 'cose key' structure that wraps the raw key which does not for Glacier Drop * feat(core): limit addresses drawer and add scroll * test: fix message signing e2e * chore(core): fix scrollbars styles --------- Co-authored-by: Martynas Kazlauskas <martynas.kazlauskas@iohk.io> Co-authored-by: Mircea Hasegan <mircea.hasegan@iohk.io> Co-authored-by: Lukasz Jagiela <Lukasz.Jagiela@iohk.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed solution
Testing
CIP-30
signData
should produce the same resultScreenshots