Skip to content

Conversation

fraser-iohk
Copy link
Contributor

Fixes breaking build when using QuickCheck-2.16 due to clashing Some now exported from Test.QuickCheck

Checklist:

  • Check source-code formatting is consistent

@ch1bo
Copy link
Member

ch1bo commented Jul 10, 2025

Tests failing with

src/Test/QuickCheck/StateModel/Variables.hs:34:1: error: [-Wdodgy-imports, Werror=dodgy-imports]
    Module ‘Test.QuickCheck’ does not export ‘Some(..)’
   |
34 | import Test.QuickCheck as QC hiding (Some (..))
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Error: cabal: Failed to build quickcheck-dynamic-4.0.0 (which is required by
test:quickcheck-dynamic-test from quickcheck-dynamic-4.0.0).

I'd suggest to do explicit imports. Making this qualified would also work, but that would lead to a bigger diff.

Copy link
Member

@ch1bo ch1bo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Not sure against which version of QuickCheck CI builds right now and we seem not to have version bounds on that dependency..

@ch1bo ch1bo merged commit c0f14d3 into input-output-hk:main Jul 10, 2025
2 checks passed
@ch1bo ch1bo mentioned this pull request Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants