Skip to content

[SYCL][CMake] Apply SYCL_LIBDEVICE_CXX_FLAGS to IMF host compile #19611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 28, 2025
Merged

[SYCL][CMake] Apply SYCL_LIBDEVICE_CXX_FLAGS to IMF host compile #19611

merged 3 commits into from
Jul 28, 2025

Conversation

sarnex
Copy link
Contributor

@sarnex sarnex commented Jul 28, 2025 •
edited
Loading

We need to apply the custom flags both to the libdevice BC file generation and the imf host compile, as these flags could contain paths to stdlibc++ or glibc which are used in both.

I forgot to do this in my change adding this flag.

@sarnex
[SYCL][CMake] Apply SYCL_LIBDEVICE_CXX_FLAGS to IMF host compile
c0fd669 
Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
@sarnex sarnex temporarily deployed to WindowsCILock July 28, 2025 16:37 — with GitHub Actions Inactive
@sarnex sarnex marked this pull request as ready for review July 28, 2025 16:45
@sarnex sarnex requested a review from a team as a code owner July 28, 2025 16:45
@sarnex
simplify args
90ba768 
Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
@sarnex sarnex temporarily deployed to WindowsCILock July 28, 2025 17:07 — with GitHub Actions Inactive
@sarnex sarnex temporarily deployed to WindowsCILock July 28, 2025 17:33 — with GitHub Actions Inactive
@sarnex
whoops
49153e7 
Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
@sarnex sarnex temporarily deployed to WindowsCILock July 28, 2025 17:43 — with GitHub Actions Inactive
@sarnex sarnex merged commit 210f332 into intel:sycl Jul 28, 2025
11 checks passed
@sarnex sarnex temporarily deployed to WindowsCILock July 28, 2025 18:09 — with GitHub Actions Inactive
@sarnex sarnex temporarily deployed to WindowsCILock July 28, 2025 18:09 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aelovikov-intel aelovikov-intel aelovikov-intel approved these changes

@sergey-semenov sergey-semenov Awaiting requested review from sergey-semenov sergey-semenov is a code owner automatically assigned from intel/llvm-reviewers-runtime

@uditagarwal97 uditagarwal97 Awaiting requested review from uditagarwal97

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sarnex @aelovikov-intel