Skip to content

fix: make typehinting for Extension.bot work #1748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2025
Merged

fix: make typehinting for Extension.bot work #1748

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions interactions/models/internal/extension.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ async def some_command(self, context):

"""

bot: "Client"
_bot: "Client"
name: str
extension_name: str
description: str
Expand Down Expand Up @@ -77,8 +77,6 @@ class Metadata:
def __new__(cls, bot: "Client", *args, **kwargs) -> "Extension":
instance = super().__new__(cls)
instance.bot = bot
instance.client = bot

instance.name = cls.__name__

if instance.name in bot.ext:
Expand Down Expand Up @@ -140,6 +138,22 @@ def __new__(cls, bot: "Client", *args, **kwargs) -> "Extension":
def __name__(self) -> str:
return self.name

@property
def bot(self) -> "Client":
return self._bot

@bot.setter
def bot(self, value: "Client") -> None:
self._bot = value

@property
def client(self) -> "Client":
return self._bot

@client.setter
def client(self, value: "Client") -> None:
self._bot = value

@property
def commands(self) -> List["BaseCommand"]:
"""Get the commands from this Extension."""
Expand Down
Loading