Skip to content

Conversation

@mikehardy
Copy link
Collaborator

Description

firebase-ios-sdk sometimes returns a zero session ID with a nil error, leading us to return zero as a session ID

I assert this is not a valid session ID so I'm going to reject for API callers in this case

Issue logged upstream

Detected in flake hammer parallel CI runs with a roughly 7% incidence in full e2e runs, example:

https://github.com/invertase/react-native-firebase/actions/runs/17225729926/job/48869796433#step:25:4846

Related issues

Release Summary

single conventional commit ready for rebase

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
    • Other (macOS, web)
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

This issue was detected via e2e runs, manual iOS e2e workflow set to run 15 instances (so it ends up running 15x debug + release, for 30 total, expect 1-3 failures on this without the patch.


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel
Copy link

vercel bot commented Aug 27, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
react-native-firebase Ready Ready Preview Comment Aug 27, 2025 3:02pm

@mikehardy mikehardy enabled auto-merge (rebase) August 27, 2025 15:33
@mikehardy mikehardy disabled auto-merge August 27, 2025 15:33
@mikehardy mikehardy merged commit 9d2a393 into main Aug 27, 2025
20 of 21 checks passed
@mikehardy mikehardy deleted the analytics-zero-sessionID branch August 27, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants