fix(analytics, ios): reject getSessionId call if id is zero #8677
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
firebase-ios-sdk sometimes returns a zero session ID with a nil error, leading us to return zero as a session ID
I assert this is not a valid session ID so I'm going to reject for API callers in this case
Issue logged upstream
Detected in flake hammer parallel CI runs with a roughly 7% incidence in full e2e runs, example:
https://github.com/invertase/react-native-firebase/actions/runs/17225729926/job/48869796433#step:25:4846
Related issues
Release Summary
single conventional commit ready for rebase
Checklist
AndroidiOSOther(macOS, web)e2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
This issue was detected via e2e runs, manual iOS e2e workflow set to run 15 instances (so it ends up running 15x debug + release, for 30 total, expect 1-3 failures on this without the patch.
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter