Skip to content

Conversation

mikehardy
Copy link
Collaborator

Description

Still thinking about how to get e2e working more reliably for iOS runs, and this PR collects those ideas

  • add system logging, plus screen video recording on the whole app for more diagnostics
  • separate the simulator boot process from Detox, it seems to hang on that frequently

Still not handled but needs to be as it happens a lot:

  • the app starts but can't find metro, and maybe a simulator terminate / erase / retry would fix it

Related issues

Release Summary

all tests, no release will trigger

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
    • Other (macOS, web)
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

It's all test work


Think react-native-firebase is great? Please consider supporting the project with any of the below:

there were two places this was defined, and I just added 429 /
quota-exceeded retries to one, both could use it though

so focus all cloud helper function usage through a single code path
also add some continue-on-error's into other, hasn't been a problem,
but the steps that will now continue-on-error should not stop the workflow
perhaps we can isolate and handle Simulator boot issues
@vercel
Copy link

vercel bot commented Aug 31, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
react-native-firebase Ready Ready Preview Comment Aug 31, 2025 1:30am

@mikehardy
Copy link
Collaborator Author

Separating the iOS Simulator boot from Detox run resulted in a drop from 33% failure to 10%, which is a pretty big improvement, going to merge.

https://github.com/invertase/react-native-firebase/actions/runs/17351439598

The 10% all share a pattern where the app went to get something external (analytics.sessionId or remoteConfig onConfigUpdate or remoteConfig activation status) and appeared to hang.
Then the jest timer of 15000000ms (25mins) ran out and jest failed the test but then the tests ran to completion afterwards.

Very strange.

Next thought is verbose jest and detox logging I suppose

@mikehardy mikehardy merged commit 9f5467a into main Aug 31, 2025
49 of 52 checks passed
@mikehardy mikehardy deleted the ios-e2e-defuzz branch August 31, 2025 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant