Skip to content

fix(angular-standalone): update eslint #1861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 0 additions & 46 deletions angular-standalone/base/.eslintrc.json

This file was deleted.

26 changes: 16 additions & 10 deletions angular-standalone/base/angular.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,10 @@
"output": "assets"
}
],
"styles": ["src/global.scss", "src/theme/variables.scss"],
"styles": [
"src/global.scss",
"src/theme/variables.scss"
],
"scripts": [],
"browser": "src/main.ts"
},
Expand Down Expand Up @@ -109,7 +112,10 @@
"output": "assets"
}
],
"styles": ["src/global.scss", "src/theme/variables.scss"],
"styles": [
"src/global.scss",
"src/theme/variables.scss"
],
"scripts": []
},
"configurations": {
Expand All @@ -122,27 +128,27 @@
"lint": {
"builder": "@angular-eslint/builder:lint",
"options": {
"lintFilePatterns": ["src/**/*.ts", "src/**/*.html"]
"lintFilePatterns": [
"src/**/*.ts",
"src/**/*.html"
]
}
}
}
}
},
"cli": {
"schematicCollections": ["@ionic/angular-toolkit"]
"schematicCollections": [
"angular-eslint",
"@ionic/angular-toolkit"
]
},
"schematics": {
"@ionic/angular-toolkit:component": {
"styleext": "scss"
},
"@ionic/angular-toolkit:page": {
"styleext": "scss"
},
"@angular-eslint/schematics:application": {
"setParserOptionsProject": true
},
"@angular-eslint/schematics:library": {
"setParserOptionsProject": true
}
}
}
48 changes: 48 additions & 0 deletions angular-standalone/base/eslint.config.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
// @ts-check
const eslint = require("@eslint/js");
const tseslint = require("typescript-eslint");
const angular = require("angular-eslint");

module.exports = tseslint.config(
{
files: ["**/*.ts"],
extends: [
eslint.configs.recommended,
...tseslint.configs.recommended,
...angular.configs.tsRecommended,
],
processor: angular.processInlineTemplates,
rules: {
"@angular-eslint/component-class-suffix": [
"error",
{
"suffixes": ["Page", "Component"]
}
],
"@angular-eslint/directive-selector": [
"error",
{
type: "attribute",
prefix: "app",
style: "camelCase",
},
],
"@angular-eslint/component-selector": [
"error",
{
type: "element",
prefix: "app",
style: "kebab-case",
},
],
},
},
{
files: ["**/*.html"],
extends: [
...angular.configs.templateRecommended,
...angular.configs.templateAccessibility,
],
rules: {},
}
);
18 changes: 5 additions & 13 deletions angular-standalone/base/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,29 +29,21 @@
},
"devDependencies": {
"@angular-devkit/build-angular": "^19.0.0",
"@angular-eslint/builder": "^19.0.0",
"@angular-eslint/eslint-plugin": "^19.0.0",
"@angular-eslint/eslint-plugin-template": "^19.0.0",
"@angular-eslint/schematics": "^19.0.0",
"@angular-eslint/template-parser": "^19.0.0",
"@angular/cli": "^19.0.0",
"@angular/compiler-cli": "^19.0.0",
"@angular/language-service": "^19.0.0",
"@ionic/angular-toolkit": "^12.0.0",
"@types/jasmine": "~5.1.0",
"@typescript-eslint/eslint-plugin": "^8.18.0",
"@typescript-eslint/parser": "^8.18.0",
"eslint": "^9.16.0",
"eslint-plugin-import": "^2.29.1",
"eslint-plugin-jsdoc": "^48.2.1",
"eslint-plugin-prefer-arrow": "1.2.2",
"angular-eslint": "19.1.0",
"eslint": "^9.20.0",
"jasmine-core": "~5.1.0",
"jasmine-spec-reporter": "~5.0.0",
"karma": "~6.4.0",
"karma-chrome-launcher": "~3.2.0",
"karma-coverage": "~2.2.0",
"karma-jasmine": "~5.1.0",
"karma-jasmine-html-reporter": "~2.1.0",
"typescript": "~5.6.3"
"typescript": "~5.6.3",
"typescript-eslint": "8.23.0"
}
}
}
2 changes: 1 addition & 1 deletion angular-standalone/base/src/zone-flags.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
* Prevents Angular change detection from
* running with certain Web Component callbacks
*/
// eslint-disable-next-line no-underscore-dangle
// eslint-disable-next-line @typescript-eslint/no-explicit-any
(window as any).__Zone_disable_customElements = true;
6 changes: 3 additions & 3 deletions angular-standalone/official/list/src/app/home/home.page.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

import { Component, inject } from '@angular/core';
import { RefresherCustomEvent, IonHeader, IonToolbar, IonTitle, IonContent, IonRefresher, IonRefresherContent, IonList } from '@ionic/angular/standalone';
import { IonHeader, IonToolbar, IonTitle, IonContent, IonRefresher, IonRefresherContent, IonList } from '@ionic/angular/standalone';
import { MessageComponent } from '../message/message.component';

import { DataService, Message } from '../services/data.service';
Expand All @@ -15,9 +15,9 @@ export class HomePage {
private data = inject(DataService);
constructor() {}

refresh(ev: any) {
refresh(ev: CustomEvent) {
setTimeout(() => {
(ev as RefresherCustomEvent).detail.complete();
(ev.target as HTMLIonRefresherElement).complete();
}, 3000);
}

Expand Down