Skip to content

Conversation

DaughterOfMars
Copy link
Contributor

Description

I did another pass over the traits and made some refactors:

  1. Split PTBArguments into two traits which solves the todo in the upgrade fn.
  2. Split MoveArg into MoveArgCollection to separate collections and single values (which also avoids weirdness with collections of collections). MoveArg is now explicitly a trait for serializing pure BCS bytes.
  3. Changed all the traits so that they accept self instead of &self which reduces the amount of cloning needed under certain circumstances. This did require some additional implementations, notably to support both owned and referenced data there must now be explicit impls for both.
  4. I removed the ArgType enum and pushed ObjectId handling up to the PTBArgument traits.

@Thoralf-M Thoralf-M merged commit 855cad2 into sdk-bindings Oct 7, 2025
14 checks passed
@Thoralf-M Thoralf-M deleted the feat/simplify-move-args branch October 7, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants