Skip to content

alignments for pyeudiw 1.0 #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 6, 2025
Merged

alignments for pyeudiw 1.0 #191

merged 9 commits into from
May 6, 2025

Conversation

peppelinux
Copy link
Member

This PR will be merged when all the tests for pyeudiw release candidate 1.0 will be completed

@peppelinux peppelinux marked this pull request as draft March 27, 2025 10:29
Copy link

gitguardian bot commented Apr 10, 2025

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
5632969 Triggered Generic Password c7f01f4 Docker-compose/env.example View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@saralongobardiacn saralongobardiacn marked this pull request as ready for review May 5, 2025 14:27
@peppelinux peppelinux requested review from elisanp and Copilot May 6, 2025 07:17
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates various configuration and template files in preparation for the pyeudiw 1.0 release candidate. Key changes include:

  • Adding an authorization error template for improved error display.
  • Updating the backend YAML configuration with new keys, blocks (including a new “duckle” block), and revised credential handling.
  • Modifying the README setup documentation and Docker Compose configuration to incorporate the new GET_SPID_IDP_METADATA flag and adjusted service build parameters.

Reviewed Changes

Copilot reviewed 4 out of 7 changed files in this pull request and generated 3 comments.

File Description
example/templates/authorization_error.html New error template for handling wallet authentication errors
example/plugins/backends/pyeudiw_backend.yaml Updated backend configuration with added keys and new blocks
README-Setup.md Updated documentation with new configuration flag
Docker-compose/docker-compose.yml Adjusted service configuration, image reference, and env vars
Files not reviewed (3)
  • Docker-compose/env.example: Language not supported
  • Dockerfile: Language not supported
  • example/entrypoint.sh: Language not supported

@@ -99,6 +100,9 @@ config:
- path:
- "$.given_name"

Copy link
Preview

Copilot AI May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider adding a brief comment explaining the purpose and usage of the newly introduced 'duckle' configuration block to improve clarity for future maintainers.

Suggested change
# The 'duckle' block defines configuration for querying digital credentials using DCQL (Digital Credential Query Language).
# It specifies the required credentials, their formats, metadata, and the claims to be extracted.

Copilot uses AI. Check for mistakes.

# args:
# - NODE_ENV=local
# dockerfile: Dockerfile
# image: ghcr.io/italia/iam-proxy-italia:latest
Copy link
Preview

Copilot AI May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider removing or updating the outdated commented image tag to avoid confusion regarding the intended image reference.

Suggested change
# image: ghcr.io/italia/iam-proxy-italia:latest

Copilot uses AI. Check for mistakes.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Collaborator

@elisanp elisanp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@peppelinux peppelinux merged commit a3ff5f1 into master May 6, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants