Skip to content

include/float8.h:NextPowerOfTwo; infinite values #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+11 −18
Open

include/float8.h:NextPowerOfTwo; infinite values #290

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26b2323
`include/float8.h:NextPowerOfTwo`; infinite values
SwuduSusuwu May 16, 2025
6291f38
`NextPowerOfTwo`; `s/unsigned int/long long/`
SwuduSusuwu May 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 11 additions & 18 deletions ml_dtypes/include/float8.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1194,26 +1194,19 @@ template <typename T>
bool constexpr IsPowerOfTwo(T x) {
return (x != 0) && ((x & (x - 1)) == 0);
}
template <long long N>
constexpr unsigned int MostSignificantBit() {
unsigned int result = 0;
long long x = N;
while (x >>= 1) {
++result;
}
return result; // return N == 0 ? 0 : (sizeof(long long) * 8 - 1 - __builtin_clz(N));
}
// Helper for getting a bytes size which is a power of two.
template <int Size>
template <long long Size>
struct NextPowerOfTwo {
static constexpr int value = Size;
};
template <>
struct NextPowerOfTwo<3> {
static constexpr int value = 4;
};
template <>
struct NextPowerOfTwo<5> {
static constexpr int value = 8;
};
template <>
struct NextPowerOfTwo<6> {
static constexpr int value = 8;
};
template <>
struct NextPowerOfTwo<7> {
static constexpr int value = 8;
static constexpr int value = IsPowerOfTwo(Size) ? Size : 2 << MostSignificantBit<Size>();
};

// Helper for getting a bit representation provided a byte size.
Expand Down