Harden revoke access token for password changes #746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andrew-Chen-Wang
approved these changes
Dec 4, 2023
|
I need this feature. When can it be merged and release? |
sevdog
force-pushed
the
harden-revoke-token-claim
branch
from
27f4675 to
cebedb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an enhancement of #719 which:
SECRET_KEY_FALLBACKSsettings (introduced in v4.1)It also cleans up a bit the authentication tests: there is no need to replicate every logic of
test_get_userintest_get_user_with_check_revoke_token.