Skip to content

remove permalink decorator #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

remove permalink decorator #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
20e8b07
remove permalink decorator and replace w/ reverse() as per https://do…
timball Oct 11, 2018
8470e73
This PR fixes one incompatibility w/ mainline django.
timball Oct 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions wordpress/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,9 +322,8 @@ def save(self, **kwargs):
self.child_cache = None
self.term_cache = None

@models.permalink
def get_absolute_url(self):
return ('wp_object_detail', (
return reverse('wp_object_detail', (
self.post_date.year,
"%02i" % self.post_date.month,
"%02i" % self.post_date.day,
Expand Down Expand Up @@ -484,9 +483,8 @@ class Meta:
def __unicode__(self):
return self.name

@models.permalink
def get_absolute_url(self):
return ('wp_archive_term', (self.slug, ))
return reverse('wp_archive_term', (self.slug, ))


class Taxonomy(WordPressModel):
Expand Down
4 changes: 2 additions & 2 deletions wordpress/urls.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from django.conf.urls import *
from wordpress.views import *

urlpatterns = patterns('wordpress.views',
urlpatterns = [

url(r'^author/(?P<username>[\w-]+)/$',
AuthorArchive.as_view(), name='wp_author'),
Expand Down Expand Up @@ -29,4 +29,4 @@
url(r'^$',
Archive.as_view(), name='wp_archive_index'),

)
]