Adapt to ports/unix MicroPython using select.poll #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 30, 2021 10:30
… to Request._waitForRecvRequest until after warning check
…tpRequest during KeepAlive
|
Thanks for submitting this PR, Norman! I started trying to fix errors in XAsyncSockets.py on my own and then decided to look through unmerged PRs when I found I needed to peel back more than one layer of this onion. After applying your changes, I am very happy to see that I run MicroWebSrv2 2.0.6 in micropython 1.14! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks, Jean-Christophe, for this great web server. It makes MicroPython very valuable, especially for our application.
The default build of ports/unix MicroPython does not provide select.poll. For consistency, this pull request replaces select.select with select.poll for all MicroPython ports. The CPython execution remains unchanged with select.select.
It has been tested using the demo application on CPython, and MicroPython ports/unix and ports/stm32.
The second commit changes main.py to warn when / fails to resolve with the default RootPath.