Skip to content

Refactor transcript scraping to use Android innertube API #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 11, 2025

Conversation

jdepoix
Copy link
Owner

@jdepoix jdepoix commented Jun 11, 2025

This PR refactors the way the captions json is retrieved from scraping it from the /watch html to fetching it from the innertube API.

While this allows us to work around the PO token enforcement for now, I didn't get cookie based authentication to work for the time being and therefore had to temporarily disable this feature, to be able to provide a fix to the issue ASAP. Other than that, all features seemed to work as expected in my testing (fetching transcript in different languages, listing transcripts, translating transcripts, using Webshare proxies to work around IP bans).

@coveralls
Copy link

coveralls commented Jun 11, 2025

Pull Request Test Coverage Report for Build 15596854143

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 14612450470: 0.0%
Covered Lines: 513
Relevant Lines: 513

💛 - Coveralls

@0xRaduan
Copy link

0xRaduan commented Jun 11, 2025

@jdepoix – tested this, works pretty reliably(on local)

@jdepoix jdepoix merged commit db46346 into master Jun 11, 2025
9 checks passed
@jdepoix jdepoix deleted the bugfix/refactor-to-use-innertube branch June 11, 2025 22:24
@dellis23
Copy link

I don't know what any of this means, but I just wanted to say I appreciate you fixing the issues with this so quickly.

@jdepoix
Copy link
Owner Author

jdepoix commented Jun 13, 2025

@dellis23 I appreciate your appreciation 😀🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants