Test with Java 21 and modernization #27
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ERROR] High: Found reliance on default encoding in io.jenkins.plugins.pipeline.restful.api.HttpFlowDefinition.create(FlowExecutionOwner, TaskListener, List): java.io.ByteArrayOutputStream.toString() [io.jenkins.plugins.pipeline.restful.api.HttpFlowDefinition] At HttpFlowDefinition.java:[line 35] DM_DEFAULT_ENCODING
[ERROR] High: Found reliance on default encoding in io.jenkins.plugins.pipeline.restful.api.InstanceAPI.doGenerateToken(StaplerResponse, String): java.io.ByteArrayOutputStream.toString() [io.jenkins.plugins.pipeline.restful.api.InstanceAPI] At InstanceAPI.java:[line 161] DM_DEFAULT_ENCODING
[ERROR] High: Found reliance on default encoding in io.jenkins.plugins.pipeline.restful.api.InstanceAPI.doGenerateToken(StaplerResponse, String): String.getBytes() [io.jenkins.plugins.pipeline.restful.api.InstanceAPI] At InstanceAPI.java:[line 167] DM_DEFAULT_ENCODING
[ERROR] Medium: Redundant nullcheck of config, which is known to be non-null in io.jenkins.plugins.pipeline.restful.api.InstanceAPI.doSetLocation(String, String) [io.jenkins.plugins.pipeline.restful.api.InstanceAPI] Redundant null check at InstanceAPI.java:[line 182] RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE
[ERROR] Medium: Should io.jenkins.plugins.pipeline.restful.api.PipelineRestfulAPI$IdentifyCause be a _static_ inner class? [io.jenkins.plugins.pipeline.restful.api.PipelineRestfulAPI$IdentifyCause] At PipelineRestfulAPI.java:[lines 305-328] SIC_INNER_SHOULD_BE_STATIC
[ERROR] Medium: Should io.jenkins.plugins.pipeline.restful.api.PipelineRestfulAPI$IdentityBuild be a _static_ inner class? [io.jenkins.plugins.pipeline.restful.api.PipelineRestfulAPI$IdentityBuild] At PipelineRestfulAPI.java:[lines 200-220] SIC_INNER_SHOULD_BE_STATIC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test with Java 21
Java 21 was released Sep 19, 2023. We want to announce full support for Java 21 in early October and would like the most used plugins to be compiled and tested with Java 21.
The acceptance test harness and plugin bill of materials tests are already passing with Java 21. This is a further step to improve plugin readiness for use with Java 21 and for development with Java 21.
The change intentionally tests only two Java configurations, Java 17 and Java 21 because we believe that the risk of a regression that only affects Java 11 is shallow. We generate Java 11 byte code with the Java 17 and the Java 21 builds, so we're already testing Java 11 byte code.
Testing done
Confirmed tests pass with Java 21 after upgrading to a recent parent POM and to Jenkins version 2.387.3 as the minimum version.