Fix sorting key for Total table header #109
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh my that's broken indeed! Thanks for the PR, that helps a ton. I do have some personal stuff going on, so not sure when I'll get to releaseing it (the check + merge is easily done soon, but building and releasing the addon in stores is a bit of manual labor at the moment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When clicking the
--- Total ---header in the Delta-focused stats table, the table doesn't sort by the completion time.This is because the sorting key provided when creating the Total header has a different sorting key than the Points header does. Changing the key from
"total"to"completion"to match the sorting key of the Points header fixes the sorting.