-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Remove reference to rtx in README #4559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
rtx has since been renamed to mise https://mise.jdx.dev/rtx.html and the creator says that it shouldn't be used to manage git. jdx/mise#4694 (comment)
So this of course, begs the question, what should we recommend for managing git versions? I could personally use this advice right now because I'm testing out some code for #4504, and there has been a lot of support for trailers added in more recent versions of git, so I want to make sure that what I write still works on different versions. Also, unrelated to the concept of this PR, but what are our ongoing rules for supported git versions? I see the list we defined that we are running in our CI is around 2 years old. #2754 Do we have any plans to bump it from 2.22.0, which came out in June 2019? (In particular to my code I'm working in, I want to use |
I'm not sure I would recommend it, but here's what I personally do:
The list was last updated four weeks ago (see #4439). But I can't really answer this question. I would personally be in favor of updating our minimum required version to a much more recent version, to make our lives easier, but @jesseduffield had reasons why he wanted to keep supporting older versions if possible. I'll let him make the call on this. |
@jesseduffield You said 2.32, but did you mean 2.31? |
I meant 2.32 because that's what @ChrisMcD1 mentioned. Indeed, 2.31 is on RHEL 9, but my understanding is that RHEL is overwhelming used for servers, not personal computers, and that lazygit would rarely be used on servers. |
I see, ok. On that note though, I'm skeptical that using |
Yeah, my ideas aren't fully formed yet either. I'll think some more and come back with a clearer idea. For this PR, what do we want to recommend people use to manage git versions? I'm just trying to save someone else from going down the 2 hour rabbit hole that ended with me discovered the maintainer of |
No idea to be honest. What I described above works well for me, but I'm not sure we want to document it; and I'm not aware of any tools that make this easy, but I also haven't looked for them. 😉 |
rtx has since been renamed to mise https://mise.jdx.dev/rtx.html and the creator says that it shouldn't be used to manage git. jdx/mise#4694 (comment)
go generate ./...
)