Refactor Lexer
to avoid lex_string_factory
#17
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces
lex_string_factory
withaccept_string_literal
and moves all state functions (lex_*
) to be methods ofLexer
instead of functions.I have thought about using
functools.partialmethod
instead, but I'm not sure that's much better than the factory function.The one downside to this approach is that
accept_string_literal
is not a true state function, but it does emit a token, which doesn't feel very neat.