save_plant: inelegant concurrency fix #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This inelegant and hackyish fix gives a randomly generated name to the temporary savefiles, so there is only a 0.1% chance of the filename being the same twice in a row. This solves the ocasional exceptions raised in save_plant, when there is more than one call still running at once, for the same user (due to slow writes).
marado
added a commit
to marado/public_html
that referenced
this pull request
Jul 29, 2021
Again a victim of botany's bugs, we're back to the begining of generation 44: You're tired of waiting for your seed to grow. Generation: 44 Growth rate: 9.6x A fix for this issue was already provided in jifunks/botany#38 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This inelegant and hackyish fix gives a randomly generated name to the
temporary savefiles, so there is only a 0.1% chance of the filename
being the same twice in a row.
This solves the ocasional exceptions raised in save_plant, when there
is more than one call still running at once, for the same user (due to
slow writes).