Skip to content

Conversation

@SystemDisc
Copy link

@SystemDisc SystemDisc commented Jul 15, 2024

This makes errors bubble up to await CommandFactory.run(...); like they should.

Example code utilizing new behavior:

import { CommandFactory } from 'nest-commander';
import { CommanderModule } from './commander.module';

async function bootstrap() {
  try {
    await CommandFactory.run(CommanderModule, ['verbose', 'debug', 'log', 'warn', 'error']);
  } catch (e) {
    process.exit(1);
  }
}

bootstrap();

This makes errors bubble up to `await CommandFactory.run(...);` like they should
@changeset-bot
Copy link

changeset-bot bot commented Jul 15, 2024

⚠️ No Changeset found

Latest commit: e04a5ea

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@alburkerk
Copy link

This should be merged.

Currently it make all scripts fails silently which is a big issue

@jmcdo29
Copy link
Owner

jmcdo29 commented Oct 22, 2024

@SystemDisc can you resolve the conflicts and add a changeset by following pnpm changeset? This should be a patch. With that, I'll get this merged and released

if (!this.options.serviceErrorHandler) {
this.options.serviceErrorHandler = (err: Error) =>
this.options.serviceErrorHandler = async (err: Error) => {
process.stderr.write(err.toString());

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it bubbles the error, should printing it not be the responsibility of the caller? I.e. adding console.error(err) to the catch block in main.ts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants