This repository was archived by the owner on Oct 18, 2022. It is now read-only.
Make command public to allow usage of custom commands
#38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many flash chips implement custom extensions, for example the GD25Q16CSIG with a 128 bit unique id or Window 25Q32JVSIQ with a 64 bit unique id. Without this change applications would need to reconstruct `SPI` after dropping `Flash` or only execute custom commands before constructing `Flash`, both rather ... unideal solutions.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many flash chips implement custom extensions, for example the
GD25Q16CSIG with a 128 bit unique id or Window 25Q32JVSIQ with a 64 bit
unique id.
Without this change applications would need to reconstruct
SPIafterdropping
Flashor only execute custom commands before constructingFlash, both rather ... unideal solutions.