Skip to content

Conversation

@denisstrizhkin
Copy link

It's a very helpful library. Howerver, most of the dependencies have really outdated version. I updated all of them and changed coloroma to termcolor as colorama only supports older python version. I run the tests. And check how the library works. All seems fine. I am open to suggestions on how to improve this pr.

> make test
===================================================================================== test session starts ======================================================================================
platform linux -- Python 3.13.5, pytest-8.4.1, pluggy-1.6.0
Using --randomly-seed=3800331330
rootdir: /home/denis/Desktop/src/findpapers
configfile: pyproject.toml
testpaths: tests
plugins: randomly-3.16.0, cov-6.2.1
collected 56 items

tests/unit/test_search_handler.py ss..                                                                                                                                                   [  7%]
tests/unit/test_pubmed_searcher.py .....                                                                                                                                                 [ 16%]
tests/unit/test_query_util.py .........                                                                                                                                                  [ 32%]
tests/unit/test_common_util.py ......                                                                                                                                                    [ 42%]
tests/unit/test_ieee_searcher.py .....                                                                                                                                                   [ 51%]
tests/unit/test_scopus_searcher.py ....s...                                                                                                                                              [ 66%]
tests/unit/test_arxiv_searcher.py ...s.                                                                                                                                                  [ 75%]
tests/unit/test_acm_searcher.py ...s                                                                                                                                                     [ 82%]
tests/unit/test_rxiv_searcher.py .                                                                                                                                                       [ 83%]
tests/unit/test_bibtex_generator.py .                                                                                                                                                    [ 85%]
tests/unit/test_models.py .s.                                                                                                                                                            [ 91%]
tests/unit/test_search_refine.py sssss                                                                                                                                                   [100%]

======================================================================================= warnings summary =======================================================================================
tests/unit/test_pubmed_searcher.py: 2 warnings
tests/unit/test_ieee_searcher.py: 2 warnings
tests/unit/test_scopus_searcher.py: 3 warnings
tests/unit/test_arxiv_searcher.py: 1 warning
tests/unit/test_acm_searcher.py: 1 warning
tests/unit/test_rxiv_searcher.py: 1 warning
tests/unit/test_bibtex_generator.py: 1 warning
  /home/denis/Desktop/src/findpapers/findpapers/models/search.py:50: DeprecationWarning: datetime.datetime.utcnow() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.now(datetime.UTC).
    self.processed_at = processed_at if processed_at is not None else datetime.datetime.utcnow()

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
======================================================================================== tests coverage ========================================================================================
_______________________________________________________________________ coverage: platform linux, python 3.13.5-final-0 ________________________________________________________________________

Name                                        Stmts   Miss  Cover
---------------------------------------------------------------
findpapers/__init__.py                         12      2    83%
findpapers/cli.py                              72     72     0%
findpapers/models/paper.py                     98      4    96%
findpapers/models/publication.py               69      3    96%
findpapers/models/search.py                   131     31    76%
findpapers/searchers/__init__.py                8      0   100%
findpapers/searchers/acm_searcher.py          106     37    65%
findpapers/searchers/arxiv_searcher.py        103     15    85%
findpapers/searchers/biorxiv_searcher.py        5      1    80%
findpapers/searchers/ieee_searcher.py         111     16    86%
findpapers/searchers/medrxiv_searcher.py        5      1    80%
findpapers/searchers/pubmed_searcher.py       131      9    93%
findpapers/searchers/rxiv_searcher.py         110     59    46%
findpapers/searchers/scopus_searcher.py       166     63    62%
findpapers/tools/__init__.py                    0      0   100%
findpapers/tools/bibtex_generator_tool.py      61      7    89%
findpapers/tools/downloader_tool.py           110     96    13%
findpapers/tools/refiner_tool.py               51     42    18%
findpapers/tools/search_runner_tool.py        247    173    30%
findpapers/utils/common_util.py                46      7    85%
findpapers/utils/persistence_util.py           10      0   100%
findpapers/utils/publication_util.py            7      0   100%
findpapers/utils/query_util.py                 83      5    94%
findpapers/utils/requests_util.py              26      1    96%
---------------------------------------------------------------
TOTAL                                        1768    644    64%
===================================================================================== slowest 3 durations ======================================================================================
18.00s call     tests/unit/test_scopus_searcher.py::test_run
7.00s call     tests/unit/test_common_util.py::test_try_success[<lambda>-None1]
1.01s call     tests/unit/test_arxiv_searcher.py::test_run
=================================================================================== short test summary info ====================================================================================
SKIPPED [1] tests/unit/test_search_handler.py:25: It needs some revision after some tool's refactoring
SKIPPED [1] tests/unit/test_search_handler.py:11: It needs some revision after some tool's refactoring
SKIPPED [1] tests/unit/test_scopus_searcher.py:57: It needs some revision after some tool's refactoring
SKIPPED [1] tests/unit/test_arxiv_searcher.py:34: It needs some revision after some tool's refactoring
SKIPPED [1] tests/unit/test_acm_searcher.py:44: It needs some revision after some tool's refactoring
SKIPPED [1] tests/unit/test_models.py:114: It needs some revision after some tool's refactoring
SKIPPED [1] tests/unit/test_search_refine.py:78: It needs some revision after some tool's refactoring
SKIPPED [1] tests/unit/test_search_refine.py:60: It needs some revision after some tool's refactoring
SKIPPED [1] tests/unit/test_search_refine.py:19: It needs some revision after some tool's refactoring
SKIPPED [1] tests/unit/test_search_refine.py:46: It needs some revision after some tool's refactoring
SKIPPED [1] tests/unit/test_search_refine.py:33: It needs some revision after some tool's refactoring
========================================================================= 45 passed, 11 skipped, 11 warnings in 28.49s =========================================================================

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant