[6.1] Removing deprecated com_search code from Language package #42892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
According to this comment, we have to postpone this to 7.0? |
|
No, this code was properly deprecated in 4.something and can be removed. The code @brianteeman is talking about is used by this code and is useless without this code, but since it hasn't been deprecated, we technically shouldn't remove it. Both aren't used anymore. |
HLeithner
added
Feature
b/c break
|
@Hackwar If this is clear to remove, can we please get confirmation and documention for the manual? |
|
It is now ready to be removed and documentation is also ready. 😃 |
4 tasks
|
This pull request has been automatically rebased to 6.1-dev. |
HLeithner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This removes the deprecated code for com_search from the language package of the CMS.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org: Add removal of com_search methods from Language Manual#482
No documentation changes for manual.joomla.org needed