[6.1] Serve site modules in ModuleHelper when in API context #46107
+7
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This change modifies ModuleHelper to process site modules when running in ApiApplication context. Currently the
/content/articles/{id}
Web Services endpoint prepares the article content (e.g.{loadmodule}
tags), but since ModuleHelper filters by the Client ID, no modules are rendered under ApiApplication.This is a very basic way to address this, open to going about it a different way if there are implications I didn't think of!
Testing Instructions
Retrieve an article with modules rendered (assuming article ID 1 uses a load module tag of some sort)
GET /api/index.php/v1/content/articles/1
Actual result BEFORE applying this Pull Request
Despite the endpoint preparing article content, ModuleHelper filters modules by Client ID, so no modules are rendered under ApiApplication.
Expected result AFTER applying this Pull Request
ModuleHelper serves site modules when under ApiApplication, resulting in modules being rendered in article content.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed