-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[6.0] Migrate from ESLint to Biome #46125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 6.0-dev
Are you sure you want to change the base?
Conversation
Did you add a line length? Would probably make sense to increase it, to have less changes in this pr. |
@laoneo The default is 80, which I believe is the same as ESLint. Happy to increase this if you'd like a specific value, although 80 is generally considered a good number. |
If I remember correctly we were going in the past with 150. But can't find any evidence right now. Perhaps @wilsonge can shed some light here. Personally, I find 80 to close. |
These here are definitely incorrect. |
@@ -19,8 +19,7 @@ | |||
"build:com_media:dev": "node --env-file=./build/development.env build/build.mjs --com-media", | |||
"watch": "node build/build.mjs --watch", | |||
"watch:com_media": "node build/build.mjs --watch-com-media", | |||
"lint:js": "eslint --config build/eslint.config.mjs build administrator/components/com_media/resources/scripts", | |||
"lint:testjs": "eslint --config build/eslint-tests.mjs tests/System", | |||
"lint": "npx @biomejs/biome lint", | |||
"lint:css": "stylelint --config build/.stylelintrc.json \"administrator/components/com_media/resources/**/*.scss\" \"administrator/templates/**/*.scss\" \"build/media_source/**/*.scss\" \"build/media_source/**/*.css\" \"templates/**/*.scss\" \"installation/template/**/*.scss\"", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the lint:css
script option perhaps also be removed?
If I saw it properly, the command would no longer work either.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I'll remove it eventually. Firstly need to port over the CSS ordering rules to Biome (if it's supported)
@laoneo Biome doesn't support |
Looks like then, otherwise there is a better alternative. |
Summary of Changes
This migrates linting from ESLint to Biome, for 2 simple reasons:
As part of this PR, I've also run the built-in formatter to try and use concise coding standards across the board.
To-Do
lint:css
task frompackage.json
@Fedik @dgrammatiko Would be nice to get your thoughts