Use npm root to find directory to place .bin
#3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
npm bincommand was removed in npm 9+ (codesuki/add-node-modules-path#23) so using this method to detect the .bin directory fails for up-to-date node installations. On Linux, theenv.PWDfallback appears to work. However, this approach does not work for Windows.This PR proposes using the
npm rootcommand instead. This is a recommended workaround in the GitHub issue linked above. This should resolve disparities between installing @boardzilla/devtools using npm vs. yarn (where yarn still has ayarn bincommand).