Ajax: Fill in & warn against automatic JSON-to-JSONP promotion #531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgol
force-pushed
the
jsonp-promotion
branch
2 times, most recently
from
87d27c7 to
560ce28
Compare
mgol
force-pushed
the
jsonp-promotion
branch
from
560ce28 to
79afd9f
Compare
So far, the patch was only warning about the automatic promotion, but it wasn't filling the behavior back to jQuery 4+. This has been fixed.
timmywil
reviewed
Oct 28, 2024
| @@ -130,6 +130,7 @@ export default [ | |||
| QUnit: false, | |||
| url: true, | |||
| compareVersions: true, | |||
| jQueryVersionSince: false, | |||
There was a problem hiding this comment.
Why wasn't this an issue before?
There was a problem hiding this comment.
This API was not used in test/data/* files previously.
timmywil
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, the patch was only warning about the automatic promotion, but it wasn't filling the behavior back to jQuery 4+. This has been fixed.