re-unite meta-schema #1610
Open
re-unite meta-schema #1610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relequestual
approved these changes
Jun 23, 2025
jdesrosiers
reviewed
Jun 23, 2025
specs/meta/meta.json
Outdated
Comment on lines
2
to
3
| "$schema": "https://json-schema.org/version/year/meta", | ||
| "$id": "https://json-schema.org/version/year/meta", |
There was a problem hiding this comment.
What's "meta"? (Sorry if it's something we discussed and I forgot.)
There was a problem hiding this comment.
Also, what's the reason for using a placeholder for "version" and "year"?
There was a problem hiding this comment.
What's "meta"?
it was late. It should just be /version/year
Also, what's the reason for using a placeholder for "version" and "year"?
It's not published yet. Just wanted to communicate the idea.
gibson042
reviewed
Jun 27, 2025
|
@jdesrosiers I've updated the $-keyword restriction using your suggestion. It's a bit direct, but simple is probably better anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Refactor
Issue & Discussion References
Summary
Re-unites the meta-schema into a single file since vocabularies are a proposal now. We will likely split it back up again when we figure out vocabs, but for now it doesn't make sense to have them separated.
Also:
x-*keywords$*keywordsDoes this PR introduce a breaking change?