Skip to content

Conversation

elcheshoro
Copy link

Thanks for creating this library it's very convenient for interacting with Netsuites REST API in node!

The issue I'm having is that the library passes the option throwHttpError: true to the got library. In the project I'm working on I want to handle certain error types differently and the most consistent want to do that is to look at the http response codes rather than comparing to string error messages which is the only option currently.

This change is to allow the person making the request to override the got options to get the desired behaviour.

I'm not completely sure this is the best solution as a user could override the auth headers so it might be better to only allow the user to override a subset of the fields.

Let me know what you think!

@julbrs
Copy link
Owner

julbrs commented Mar 31, 2025

Thanks for the contribution! The credits must go to @ehmad11, the original maintainer of netsuite-rest and suiteql!

I will get a look at that tonight. I still have some issues when running checks on PR, I need to resolve that first 😇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants