Allow override values for got request options #41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for creating this library it's very convenient for interacting with Netsuites REST API in node!
The issue I'm having is that the library passes the option
throwHttpError: true
to the got library. In the project I'm working on I want to handle certain error types differently and the most consistent want to do that is to look at the http response codes rather than comparing to string error messages which is the only option currently.This change is to allow the person making the request to override the got options to get the desired behaviour.
I'm not completely sure this is the best solution as a user could override the auth headers so it might be better to only allow the user to override a subset of the fields.
Let me know what you think!