-
Notifications
You must be signed in to change notification settings - Fork 72
feat: Update swagger.yaml to improve descriptions and add format spec #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ifications for integer types
@sssionggg @0xYankee-Raccoons @cmoutafidis could you please take a look at this? It’s a small change, but it improves the generated code from the OpenAPI schema, especially for strongly typed languages like Go. @iamnivekx proposed to extend the main schema with the This will be super useful for the future support of https://github.com/ilkamo/jupiter-go as we use the OpenAPI schema to generate the right types. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey, commented the correct sizes
also, after changing the schema, please run |
@0xYankee-Raccoons |
@iamnivekx need you to run |
let's close this PR @iamnivekx @ilkamo, we have discussed and will be using the schema from https://dev.jup.ag/docs/api/swap-api (as the aim of the schema in dev docs will be the most updated and source of truth for both team and integrators) |
Wouldn’t it be better to keep the code aligned with the schema at https://dev.jup.ag/docs/api/swap-api? That helps avoid any mismatch between docs and implementation. That’s what I aimed for with this PR. |
#67