Skip to content

Conversation

xaskii
Copy link
Contributor

@xaskii xaskii commented Jul 9, 2025

References

Closes #1136

Code changes

User-facing changes

  • Exposes diagnostics and other LSP operations from Pyrefly

Notes

  • Change in review for supporting didChangeConfiguration notifications with settings since Jupyter Lab doesn't use workspace/configuration requests
  • Thanks for maintaining this project!

Chores

  • linted
  • tested
  • documented
  • changelog entry

Copy link

github-actions bot commented Jul 9, 2025

Binder 👈 Launch a binder notebook on branch xaskii/jupyterlab-lsp/add-pyrefly

@krassowski
Copy link
Member

Once you rebase on main the CI failures should go away

@xaskii xaskii force-pushed the add-pyrefly branch 2 times, most recently from 2b99684 to 0e69f84 Compare July 22, 2025 10:38
@xaskii xaskii marked this pull request as ready for review July 22, 2025 10:38
@xaskii
Copy link
Contributor Author

xaskii commented Jul 22, 2025

Thanks for fixing CI. I tried to follow the docs as faithfully as I can, but I'll try to respond quickly if anything needs to be changed.

Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @xaskii! Thank you for the patience here.

The CI failure is unrelated and got addressed in #1150.

@krassowski krassowski merged commit db92d8a into jupyter-lsp:main Aug 9, 2025
41 of 45 checks passed
@krassowski
Copy link
Member

@xaskii this was released in https://github.com/jupyter-lsp/jupyterlab-lsp/releases/tag/jupyter-lsp-2.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contributing Pyrefly LSP specification [ide] jupyter lab integration for notebooks
2 participants