Skip to content

Fix: prevent [None] being passed to LDAP search attributes #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+5 −2
Open

Fix: prevent [None] being passed to LDAP search attributes #304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7414fcc
Fix: prevent [None] being passed to LDAP search attributes
sr-rossanderson Jul 25, 2025
76a308d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@ See [our definition of contributors](https://github-activity.readthedocs.io/en/l
- `lookup_dn` now rejects an authenticating user if multiple DNs are returned
during lookup. ([#276](https://github.com/jupyterhub/ldapauthenticator/pull/276))
- In the edge case if both...

1. the following config is used:
- `lookup_dn = True`,
- `lookup_dn_user_dn_attribute = "cn"`
Expand Down
6 changes: 5 additions & 1 deletion ldapauthenticator/ldapauthenticator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,11 @@ def resolve_username(self, username_supplied_by_user):
search_base=self.user_search_base,
search_scope=ldap3.SUBTREE,
search_filter=search_filter,
attributes=[self.lookup_dn_user_dn_attribute],
attributes=(
[self.lookup_dn_user_dn_attribute]
if self.lookup_dn_user_dn_attribute
else ldap3.ALL_ATTRIBUTES
),
)

# identify unique search response entry
Expand Down