Skip to content

Installer FIXME: Only warn on failed install from requirements url #1041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Installer FIXME: Only warn on failed install from requirements url #1041

wants to merge 1 commit into from

Conversation

jrdnbradford
Copy link
Contributor

Resolves a FIXME in tljh/installer.py so that the TLJH installation continues with a warning if there is an exception installing requirements passed to --user-requirements-txt-url.

New behavior can be tested locally:

.github/integration-test.py run-test integration-tests \         
    --installer-args="--user-requirements-txt-url=https://example.com/fake-requirements.txt" \
    test_hub.py \
    test_install.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
PR triage (experimental)
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jrdnbradford