Skip to content

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Aug 6, 2025

Follow-up to #203

@jtpio jtpio added the bug Something isn't working label Aug 6, 2025
Copy link
Contributor

github-actions bot commented Aug 6, 2025

lite-badge 👈 Try it on ReadTheDocs

@jtpio jtpio added this to the 0.7.0 milestone Aug 6, 2025
@jtpio jtpio marked this pull request as ready for review August 6, 2025 19:13
@jtpio jtpio requested a review from bollwyvl August 6, 2025 19:13
@bollwyvl
Copy link
Contributor

bollwyvl commented Aug 6, 2025

Thanks for catching this :P

I never got around to checking all the upstream notebooks, will do so now.

@bollwyvl
Copy link
Contributor

bollwyvl commented Aug 6, 2025

Had a look through everything:

  • it's possible to get some setTime errors when doing things fast
    • maybe happens on 0.6.3
  • --force-reinstall "works" (it updated the files on disk)
    • but then importlib.reload doesn't work
    • so maybe instead we pull the feature?

@jtpio
Copy link
Member Author

jtpio commented Aug 7, 2025

Nice, thanks for checking this!

If it's already a fix, then I'm happy to get this in so we can have a first pre-release out.

@jtpio
Copy link
Member Author

jtpio commented Aug 7, 2025

OK following up with a 0.7 pre-release this time.

@jtpio jtpio merged commit 7de6a58 into jupyterlite:main Aug 7, 2025
14 checks passed
@jtpio jtpio deleted the fix-reinstall branch August 7, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants