Skip to content

BE: Extend config sanitizer patterns #1036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2025

Conversation

JoshRamynke
Copy link
Contributor

@JoshRamynke JoshRamynke commented Apr 21, 2025

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? Add "passphrase" as a default pattern to sanitize in the configs.

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Apr 21, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi JoshRamynke! 👋

Welcome, and thank you for opening your first PR in the repo!

Please wait for triaging by our maintainers.

Please take a look at our contributing guide.

@JoshRamynke JoshRamynke marked this pull request as ready for review April 21, 2025 22:47
@JoshRamynke JoshRamynke requested a review from a team as a code owner April 21, 2025 22:47
@Haarolean Haarolean changed the title Add passphrase to default config sanitizer pattern BE: Extend config sanitizer patterns Apr 22, 2025
@Haarolean Haarolean added scope/backend Related to backend changes type/chore Boring stuff, could be refactoring or tech debt and removed status/triage/manual Manual triage in progress labels Apr 22, 2025
@Haarolean Haarolean added this to the 1.3 milestone Apr 22, 2025
@Haarolean Haarolean enabled auto-merge (squash) April 22, 2025 06:27
@Haarolean Haarolean merged commit 371be00 into kafbat:main Apr 22, 2025
40 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Release 1.3 Apr 22, 2025
@Haarolean
Copy link
Member

@JoshRamynke thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/backend Related to backend changes status/triage/completed Automatic triage completed type/chore Boring stuff, could be refactoring or tech debt
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants