-
-
Notifications
You must be signed in to change notification settings - Fork 177
BE: Serde: Impl MM2 serdes #1381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add Unit tests covering these serdes
And register them to default topic names, same as ConsumerOffsets
https://github.com/kafbat/kafka-ui/blob/main/api/src/main/java/io/kafbat/ui/serdes/SerdesInitializer.java#L144
api/src/main/java/io/kafbat/ui/serdes/builtin/mm2/CheckpointSerde.java
Outdated
Show resolved
Hide resolved
api/src/main/java/io/kafbat/ui/serdes/builtin/mm2/CheckpointSerde.java
Outdated
Show resolved
Hide resolved
api/src/main/java/io/kafbat/ui/serdes/builtin/mm2/CheckpointSerde.java
Outdated
Show resolved
Hide resolved
api/src/main/java/io/kafbat/ui/serdes/builtin/mm2/CheckpointSerde.java
Outdated
Show resolved
Hide resolved
|
What changes did you make? (Give an overview)
Implemented mm2 serdes. Fixes #444
Is there anything you'd like reviewers to focus on?
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)