Skip to content

Conversation

Haarolean
Copy link
Member

@Haarolean Haarolean commented Sep 25, 2025

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
Implemented mm2 serdes. Fixes #444

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@Haarolean Haarolean self-assigned this Sep 25, 2025
@kapybro kapybro bot added status/triage Issues pending maintainers triage area/serde Serialization & Deserialization (plugins) status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Sep 25, 2025
Copy link
Member

@germanosin germanosin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add Unit tests covering these serdes
And register them to default topic names, same as ConsumerOffsets
https://github.com/kafbat/kafka-ui/blob/main/api/src/main/java/io/kafbat/ui/serdes/SerdesInitializer.java#L144

@Haarolean Haarolean added scope/backend Related to backend changes type/feature A brand new feature and removed status/triage/completed Automatic triage completed labels Sep 26, 2025
@Haarolean Haarolean added this to the 1.4 milestone Sep 26, 2025
@Haarolean
Copy link
Member Author

Please also add Unit tests covering these serdes And register them to default topic names, same as ConsumerOffsets https://github.com/kafbat/kafka-ui/blob/main/api/src/main/java/io/kafbat/ui/serdes/SerdesInitializer.java#L144

  • tests have been already added
  • added serde registration for well-known topic patterns

@Haarolean Haarolean marked this pull request as ready for review September 29, 2025 15:06
@Haarolean Haarolean requested a review from a team as a code owner September 29, 2025 15:06
@Haarolean Haarolean moved this from Todo to Changes requested in Release 1.4 Sep 29, 2025
@github-project-automation github-project-automation bot moved this from Changes requested to PR Approved in Release 1.4 Sep 30, 2025
@Haarolean Haarolean requested a review from iliax September 30, 2025 15:55
@Haarolean Haarolean added the hacktoberfest-accepted PRs accepted towards hacktoberfest goal and will be counted as approved label Oct 5, 2025
@Haarolean Haarolean enabled auto-merge (squash) October 6, 2025 12:55
@Haarolean Haarolean merged commit e21f6fb into main Oct 6, 2025
13 of 16 checks passed
@Haarolean Haarolean deleted the issues/444-mm2-serdes branch October 6, 2025 14:18
@github-project-automation github-project-automation bot moved this from PR Approved to Done in Release 1.4 Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/serde Serialization & Deserialization (plugins) hacktoberfest-accepted PRs accepted towards hacktoberfest goal and will be counted as approved scope/backend Related to backend changes type/feature A brand new feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

BE: Serde: Support mm2 topics serdes
3 participants