Skip to content

Conversation

wernerdv
Copy link
Contributor

@wernerdv wernerdv commented Mar 8, 2025

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
Migrate provectus/kafka-ui#4390 by @philosomniac
Resolve #898

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@wernerdv wernerdv requested a review from a team as a code owner March 8, 2025 20:24
@kapybro kapybro bot added status/triage Issues pending maintainers triage area/sr Schema Registry status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Mar 8, 2025
@wernerdv wernerdv changed the title FE: SR: Produce message validation fails for valid JSON schema with a… FE: SR: Add schema validation support for more json-schema version refs Mar 8, 2025
@Haarolean Haarolean self-requested a review March 8, 2025 20:49
@Haarolean Haarolean added scope/frontend Related to frontend changes type/bug Something isn't working area/messages and removed area/sr Schema Registry status/triage/manual Manual triage in progress labels Mar 10, 2025
@Haarolean Haarolean added this to the 1.2 milestone Mar 10, 2025
@Haarolean Haarolean changed the title FE: SR: Add schema validation support for more json-schema version refs FE: Messages: Add schema validation support for more json-schema version refs Mar 10, 2025
@Haarolean Haarolean merged commit dfcb65e into kafbat:main Mar 10, 2025
37 of 38 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Release 1.2 Mar 10, 2025
@Haarolean
Copy link
Member

@wernerdv thank you!

@wernerdv wernerdv deleted the issues/898 branch March 10, 2025 17:25
git-halinka pushed a commit to sainsburys-tech/kafka-ui that referenced this pull request Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/messages scope/frontend Related to frontend changes status/triage/completed Automatic triage completed type/bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

FE: Messages: Produce fails for JSON schema with a reference
2 participants