Skip to content

Use cronjob type correctly #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use cronjob type correctly #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions kubernetes/workloads.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,11 +575,10 @@ def body(self):
workload = StatefulSet(name=name, config=config.model_dump())
elif config.type == WorkloadTypes.DAEMONSET:
workload = DaemonSet(name=name, config=config.model_dump())
elif config.type == WorkloadTypes.CRONJOB:
workload = CronJob(name=name, config=config.model_dump())
elif config.type == WorkloadTypes.JOB:
if config.schedule:
workload = CronJob(name=name, config=config.model_dump())
else:
workload = Job(name=name, config=config.model_dump())
workload = Job(name=name, config=config.model_dump())
elif config.type == WorkloadTypes.CLOUD_RUN_SERVICE:
workload = CloudRunService(name=name, config=config.model_dump())
else:
Expand Down Expand Up @@ -637,8 +636,8 @@ def body(self):
self._add_component(FrontendConfig, "frontend_config", spec=self.config.frontend_config)


# Handling a special case where pdb_min_available or auto_pdb is set, but config.type isn't "job"
if self.config.type != "job" and (
# Handling a special case where pdb_min_available or auto_pdb is set, but config.type isn't "job" or "cronjob"
if (self.config.type != WorkloadTypes.JOB and self.config.type != WorkloadTypes.CRONJOB) and (
self.config.pdb_min_available or self.config.auto_pdb
):
config_attr = "pdb_min_available" if self.config.pdb_min_available else "auto_pdb"
Expand Down