Support APIExportEndpointSlices / kcp 0.28 #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcp-ci-bot
added
do-not-merge/work-in-progress
|
/retest |
kcp-ci-bot
added
size/XXL
xrstf
changed the title
kcp-ci-bot
removed
the
do-not-merge/work-in-progress
|
/retest |
kcp-ci-bot
added
release-note
xrstf
force-pushed
the
endpointslices
branch
from
1a48887 to
b0a948f
Compare
kcp-ci-bot
added
the
needs-rebase
On-behalf-of: @SAP christoph.mewes@sap.com
On-behalf-of: @SAP christoph.mewes@sap.com
On-behalf-of: @SAP christoph.mewes@sap.com
On-behalf-of: @SAP christoph.mewes@sap.com
On-behalf-of: @SAP christoph.mewes@sap.com
On-behalf-of: @SAP christoph.mewes@sap.com
On-behalf-of: @SAP christoph.mewes@sap.com
On-behalf-of: @SAP christoph.mewes@sap.com
…te the AEES On-behalf-of: @SAP christoph.mewes@sap.com
On-behalf-of: @SAP christoph.mewes@sap.com
On-behalf-of: @SAP christoph.mewes@sap.com
xrstf
force-pushed
the
endpointslices
branch
from
b0a948f to
f3e6ee2
Compare
kcp-ci-bot
removed
the
needs-rebase
|
LGTM label has been added. Git tree hash: 02a8f23513c0219049ab3b1204ad18b06735e37f
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: embik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This implements support for APIExportEndpointSlices (AEES).
Starting with kcp 0.28, APIExports do not contain the virtual workspace URLs anymore (unless you specify a feature flag on kcp, and we certainly do not want to make that required for running the Agent). Instead in 0.28+, kcp will automatically create an AEES for each new APIExport, using the same name as the export.
In kcp 0.27, admins can manually create an AEES for their APIExport, but are not forced to because kcp still makes the URLs available in the APIExport.
To handle each and every situation, the agent now simply supports both scenarios. You can run it like before with
--apiexport-refif you're still on 0.27, or you can use--apiexportendpointslice-refwhen you are in kcp 0.28+ or you make use of custom AEES in 0.27 already. The agent'smainfunction will simply resolve the flags as before and figure it all out, so the main meat part of the agent can remain unchanged.What Type of PR Is This?
/kind feature
Related Issue(s)
Fixes #86
Release Notes