provide a way to find the bytes read from Buffer #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Toxicable
pushed a commit
to Toxicable/binary-parser
that referenced
this pull request
Aug 3, 2018
This change could possibly be breaking. Another way to do it would be wrap the return value into another object.
```
return { bytesRead: offset, vars}
```
But that 100% would be a breaking change
This allows users to post parsing check the length of the input buffer agasint the number of bytes read from it.
Which can make it easier to point out bugs in the application.
---
I've another PR for this here: keichi#86
But I like the encoding functionality that you've put together aswell.
|
I think this is a better approach: #89 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change could possibly be breaking. Another way to do it would be wrap the return value into another object.
But that 100% would be a breaking change
This allows users to post parsing check the length of the input buffer agasint the number of bytes read from it.
Which can make it easier to point out bugs in the application.