Add the description that 0 should not in the arg axes in keras.layers.dot()
#21718
Conversation
Summary of ChangesHello @ILCSFNO, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the clarity of the Keras API documentation. Specifically, it addresses an ambiguity in the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a helpful clarification to the keras.layers.dot function's docstring, indicating that axis 0 cannot be used for the dot product. I've provided a suggestion to improve the wording for better clarity and to provide more context to the user.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21718 +/- ##
=======================================
Coverage 82.60% 82.60%
=======================================
Files 572 572
Lines 58326 58326
Branches 9134 9134
=======================================
Hits 48179 48179
Misses 7817 7817
Partials 2330 2330
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| inputs: A list of input tensors (at least 2). | ||
| axes: Integer or tuple of integers, | ||
| axis or axes along which to take the dot product. | ||
| Note that axis `0` (the batch axis) cannot be included. |
There was a problem hiding this comment.
Please also add line 229 (class Dot) and line 43 (batch_dot).
google-ml-butler
bot
added
kokoro:force-run
ready to pull
+1 |
Fixes #21717