Update timezones.json #55
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[fix] simplified geometry to a consistent level-of-details [fix] replaced degenerate regions with boxes centered on pin positions [fix] fixed Port_Moresby to include Papua New Guinea [fix] fixed Indian/Antananarivo to include Madagascar [fix] replaced a bunch of timezones that are not supported by Intl with what I believe are the correct timezones
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[fix] simplified geometry to a consistent level-of-details
[fix] replaced degenerate regions with boxes centered on pin positions
[fix] fixed Port_Moresby to include Papua New Guinea
[fix] fixed Indian/Antananarivo to include Madagascar
[fix] replaced a bunch of timezones that are not supported by Intl with what I believe are the correct timezones
I used your timezones.json to build my own widget and found a whole bunch of issues. That said, this is the best such widget I've found—by far—and the polygon data is better than stuff I paid to have done. I figured you probably worked pretty hard on it, so I figured I'd give back.
I wrote a small polygon library to clean up the polygons (make them consistently detailed) and fixed some issues with typos or just weird Intl crap that was stopping my widget from working.
If you're interested, my web-component is here…
https://github.com/tonioloewald/xinks-timezone-picker