Skip to content

Make models serializable #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Make models serializable #149

wants to merge 8 commits into from

Conversation

@Simply007
Copy link
Contributor

@Simply007 Simply007 commented Sep 1, 2023

Motivation

Fixes #148

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docs have been updated (if applicable)
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

If manual testing is required, what are the steps?

@Simply007 Simply007 mentioned this pull request Sep 1, 2023
Closed
@Simply007 Simply007 changed the title Make models serialozable Make models serializable Sep 6, 2023
@Simply007 Simply007 force-pushed the fix/148/make-models-serializable branch from 6a0541f to 1a9d384 Compare September 7, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IvanKiral IvanKiral Awaiting requested review from IvanKiral IvanKiral will be requested when the pull request is marked ready for review IvanKiral is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The model classes generated using delivery-sdk-generators don't extend Serializable interface hence not able cache those entries at client side.

3 participants

@Simply007 @yayatitech