Skip to content

Conversation

@sevcik-martin
Copy link
Contributor

@sevcik-martin sevcik-martin commented Nov 5, 2025

Motivation

Which issue does this fix? Fixes #EN-628

Removes depricated legacy webhooks

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docs have been updated (if applicable)
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

If manual testing is required, what are the steps?

@sevcik-martin sevcik-martin requested review from a team and pokornyd as code owners November 5, 2025 14:48
Copy link
Member

@pokornyd pokornyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like all related logic was removed. I noticed there are leftover test data and code samples that are no longer referenced anywhere:

Kontent.Ai.Management.Tests/Data/CodeSamples/PostLegacyWebhookResponse.json
Kontent.Ai.Management.Tests/Data/CodeSamples/LegacyWebhook.json
Kontent.Ai.Management.Tests/Data/LegacyWebhook/LegacyWebhook.json
Kontent.Ai.Management.Tests/Data/CodeSamples/LegacyWebhooks.json
Kontent.Ai.Management.Tests/Data/LegacyWebhook/LegacyWebhooks.json

I would delete those as well before merging, otherwise looking good.

@sevcik-martin sevcik-martin force-pushed the EN-628_remove_legacy_webhooks branch from 8c358c5 to ff4578e Compare November 9, 2025 10:23
@pokornyd pokornyd self-requested a review November 10, 2025 11:40
@pokornyd pokornyd merged commit 795489a into master Nov 10, 2025
3 checks passed
@pokornyd pokornyd deleted the EN-628_remove_legacy_webhooks branch November 10, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants