Skip to content

Added support for server sent events in Krakend Community Edition #1004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Harsh-Naicker
Copy link

@Harsh-Naicker Harsh-Naicker commented May 18, 2025

  • Added support for server sent events so that they are not buffered in Krakend
  • Added testing code to validate new implementation.

Related issue: #924

… krakend (#1)

- Added support for server sent events so that they are not buffered in Krakend
- Added testing code to validate new implementation.
@alombarte
Copy link
Member

Hello @Harsh-Naicker , thank you for submitting an interesting feature to KrakenD. A few quick comments (without deeply reviewing the code). These are more form than content:

  1. The SSE feature shouldn’t live in KrakenD-CE since that repo is for dependency stacking only, it needs its own repo.
  2. Using SSE must enforce no-op output encoding programmatically, not rely on config.
  3. All tests must be in Go, not JS; currently, the test setup is out of scope for KrakenD’s core testing practices.

@Harsh-Naicker
Copy link
Author

Harsh-Naicker commented May 20, 2025

@alombarte Thank you so much for taking a brief look at my PR. Should I do the following:

  1. Wait for your detailed review on the code.
  2. Create a new repository with the SSE support code with all the comments addressed from your review.
  3. Update this PR to use the new module as a dependency.

Awaiting your kind response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants