-
Notifications
You must be signed in to change notification settings - Fork 95
Add filesystem cache to reduce API calls #470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add filesystem cache to reduce API calls #470
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: infinite-turtles The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
|
Welcome @infinite-turtles! |
|
Hi @infinite-turtles. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
/test pull-aws-fsx-csi-driver-e2e |
|
We just merged a fix to the e2e that should resolve the current test issue |
|
@infinite-turtles can you sign the CLA auth? |
|
@infinite-turtles |
|
Reaching out to our internal OpenSource committee to see if they will authorize the CLA |
|
Hi @infinite-turtles |
This PR fixes API throttling and provisioning failures that occur during concurrent
CreateVolumerequests at scale.The previous implementation scanned all FSx filesystems on every
CreateVolumecall. This change introduces a local filesystem cache populated by a background poller.FindFileSystemByVolumeNamenow performs a fast lookup against the cache.CreateFileSystemandDeleteFileSystemare updated to keep the cache consistent between polls.Mitigates #469